Fix ROCKSDB_PLUGIN typo in get_rocksdb_files.sh#1335
Conversation
I'm guessing this was copy/pasted from a Makefile sort of syntax, whereas it meant to include the contents of these environment variables in this bash script. When I tried to build mysqld from this it was crashing here saying things like `ROCKSDB_PLUGIN_BUILTINS: command not found` because this syntax in bash means to execute a subcommand.
|
Hi @adregner! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
2 participants
I'm guessing this was copy/pasted from a Makefile sort of syntax, whereas it meant to include the contents of these environment variables in this bash script. When I tried to build mysqld from this it was crashing here saying things like
ROCKSDB_PLUGIN_BUILTINS: command not foundbecause this syntax in bash means to execute a subcommand.