This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Fix GCC compilation error in memory_debugging.h#1475
Closed
laurynas-biveinis wants to merge 1 commit into
Closed
Conversation
Replace a multi-line comment with a disabled preprocessor block
This fixes, with GCC:
In file included from include/my_alloc.h:41,
from mysys/array.cc:38:
include/memory_debugging.h:44:1: error: multi-line comment [-Werror=comment]
44 | // #define MEM_DEFINED_IF_ADDRESSABLE(a, len) \
| ^
Squash with fdf68f7
|
@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 02461d9. |
sunshine-Chun
pushed a commit
to sunshine-Chun/mysql-5.6
that referenced
this pull request
Sep 4, 2024
Summary:
Replace a multi-line comment with a disabled preprocessor block
This fixes, with GCC:
In file included from include/my_alloc.h:41,
from mysys/array.cc:38:
include/memory_debugging.h:44:1: error: multi-line comment [-Werror=comment]
44 | // #define MEM_DEFINED_IF_ADDRESSABLE(a, len) \
| ^
Squash with fdf68f7
Pull Request resolved: facebook#1475
GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Reviewers: chni, #mysql_eng
Reviewed By: chni
Differential Revision: https://phabricator.intern.facebook.com/D60675137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a multi-line comment with a disabled preprocessor block
This fixes, with GCC:
In file included from include/my_alloc.h:41,
from mysys/array.cc:38:
include/memory_debugging.h:44:1: error: multi-line comment [-Werror=comment]
44 | // #define MEM_DEFINED_IF_ADDRESSABLE(a, len)
| ^
Squash with fdf68f7