Snapshot time-related cleanups #1487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make m_earliest_snapshot_ts and m_read_opts protected fields in
Rdb_transaction class. To replace
their previous public uses, introduce new methods get_snapshot_timestamp &
create_explicit_snapshot; use has_snapshot in more places.
Remove unused return value for rdb_tx_acquire_snapshot.
- Factor out Rdb_transaction::on_finish for the common code in on_commit and
on_rollback methods.
- Delete move constructor and move assignment operator for
Rdb_compact_filter_factory class, replace "{}" with "= default" for other
special members.
- Extract the gnarly regexes to make SHOW ENGINE ROCKSDB TRANSACTION STATUS
output deterministic to a separate include file
mysql-test/suite/rocksdb/include/show_transaction_status.inc
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| virtual void release_snapshot(TABLE_TYPE table_type) = 0; | ||
|
|
||
| bool has_snapshot(TABLE_TYPE table_type) const { | ||
| assert(m_read_opts[INTRINSIC_TMP].snapshot == nullptr); |
Contributor
There was a problem hiding this comment.
Hey Laurynas, I wonder why the snapshot for intrinsic tmp table is always null?
Contributor
Author
There was a problem hiding this comment.
Temp tables are always private to the owning connection and don't need to participate in isolation concerns
|
This pull request has been merged in 1888f30. |
sunshine-Chun
pushed a commit
to sunshine-Chun/mysql-5.6
that referenced
this pull request
Sep 4, 2024
Summary:
- Make m_earliest_snapshot_ts and m_read_opts protected fields in
Rdb_transaction class. To replace
their previous public uses, introduce new methods get_snapshot_timestamp &
create_explicit_snapshot; use has_snapshot in more places.
Remove unused return value for rdb_tx_acquire_snapshot.
- Factor out Rdb_transaction::on_finish for the common code in on_commit and
on_rollback methods.
- Delete move constructor and move assignment operator for
Rdb_compact_filter_factory class, replace "{}" with "= default" for other
special members.
- Extract the gnarly regexes to make SHOW ENGINE ROCKSDB TRANSACTION STATUS
output deterministic to a separate include file
mysql-test/suite/rocksdb/include/show_transaction_status.inc
Pull Request resolved: facebook#1487
GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Reviewers: rpan, #mysql_eng
Reviewed By: rpan
Differential Revision: https://phabricator.intern.facebook.com/D61214541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rdb_transaction class. To replace
their previous public uses, introduce new methods get_snapshot_timestamp &
create_explicit_snapshot; use has_snapshot in more places.
Remove unused return value for rdb_tx_acquire_snapshot.
on_rollback methods.
Rdb_compact_filter_factory class, replace "{}" with "= default" for other
special members.
output deterministic to a separate include file
mysql-test/suite/rocksdb/include/show_transaction_status.inc