MyRocks: allocate WriteBatch objects directly on stack or in containing object #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng object This saves one level of indirection and an extra heap allocation. - Rdb_writebatch_impl: remove pointer from m_batch field, make is_tx_started return true instead of checking the pointer, remove pointer check from rollback_stmt, remove new/delete from the constructor and the destructor. - Make Rdb_dict_manager::begin return object directly instead of a unique_ptr and make this method static. - In the affected callstacks, replace WriteBatchBase / WriteBatch pointer arguments with reference ones, remove an unused error return from Rdb_dict_manager::commit and any "!= nullptr" assertions. - Rdb_transaction: change get_write_batch return type to WriteBatchBase reference instead of a pointer. - Add [[nodiscard]] to touched methods, although not universally, as several methods have their return values ignored. Remove redundant const from by-value parameters.
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in ebcd17e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves one level of indirection and an extra heap allocation.
return true instead of checking the pointer, remove pointer check from
rollback_stmt, remove new/delete from the constructor and the destructor.
and make this method static.
arguments with reference ones, remove an unused error return from
Rdb_dict_manager::commit and any "!= nullptr" assertions.
reference instead of a pointer.
methods have their return values ignored. Remove redundant const from by-value
parameters.