Fix GCC build regression #1491
Closed
Fix GCC build regression #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes
mysys/charset.cc: In member function 'virtual int MY_CHARSET_LOADER::add_collation(CHARSET_INFO*)':
mysys/charset.cc:232:13: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct CHARSET_INFO' with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
232 | memset(all_charsets[cs->number], 0, sizeof(CHARSET_INFO));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from mysys/charset.cc:43:
include/m_ctype.h:383:8: note: 'struct CHARSET_INFO' declared here
383 | struct CHARSET_INFO {
| ^~~~~~~~~~~~
Fix by removing memset and passing MY_ZEROFILL flag to the allocation function
instead.
Squash with 6637b51
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 02369bd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
mysys/charset.cc: In member function 'virtual int MY_CHARSET_LOADER::add_collation(CHARSET_INFO*)':
mysys/charset.cc:232:13: error: 'void* memset(void*, int, size_t)' clearing an object of type 'struct CHARSET_INFO' with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
232 | memset(all_charsets[cs->number], 0, sizeof(CHARSET_INFO));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from mysys/charset.cc:43:
include/m_ctype.h:383:8: note: 'struct CHARSET_INFO' declared here
383 | struct CHARSET_INFO {
| ^~~~~~~~~~~~
Fix by removing memset and passing MY_ZEROFILL flag to the allocation function
instead.
Squash with 6637b51