Assert that explicit transaction snapshot never overwrites an older one #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@laurynas-biveinis , could you do a rebase? |
Explicit transaction snapshots are maintained by std::shared_ptr objects. When the last shared pointer is destructed, the shared snapshot is released. Add asserts that these snapshots are not held too long by checking that, whenever a new explicit snapshot is assigned to a transaction, that it does not overwrite an older existing one. To be able to cover all the places and to clean up the code, make the m_explicit_snapshot field protected instead of public, and add a few new methods instead. At the same time convert pointer to reference arguments, add [[nodiscard]], shorten Rdb_explicit_snapshot::explicit_snapshot_mutex critical sections.
laurynas-biveinis
force-pushed
the
cleanup-explicit-snapshot
branch
from
70dfe2a to
0583c62
Compare
|
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
@luqun , rebased |
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in d76fb0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit transaction snapshots are maintained by std::shared_ptr objects. When
the last shared pointer is destructed, the shared snapshot is released. Add
asserts that these snapshots are not held too long by checking that, whenever a
new explicit snapshot is assigned to a transaction, that it does not overwrite
an older existing one.
To be able to cover all the places and to clean up the code, make the
m_explicit_snapshot field protected instead of public, and add a few new methods
instead.
At the same time convert pointer to reference arguments, add [[nodiscard]],
shorten Rdb_explicit_snapshot::explicit_snapshot_mutex critical sections.