Fix LLVM 18 compilation errors #1496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bladepan
reviewed
Oct 11, 2024
laurynas-biveinis
force-pushed
the
llvm-18-fixes
branch
from
94f9a80 to
5c3892e
Compare
- struct CHARSET_INFO: initialize all fields to zero, as memset is no longer valid on its variables since acquiring an std::atomic field - my_charset_file_reset_charset: placement-new construct an new default object instead of memset'ing it to zero, fixing [1] - strings/conf_to_src.cc: do not memset an object that is already default-initialized to zero, fixing [2] - partially revert the previous change [3] that asked for zero'ed memory and use placement new instead too. Squash with 6637b51 [1]: strings/ctype.cc: In function ‘void my_charset_file_reset_charset(MY_CHARSET_FILE*)’: strings/ctype.cc:303:9: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct CHARSET_INFO’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess] 303 | memset(&i->cs, 0, sizeof(i->cs)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from strings/ctype.cc:36: include/m_ctype.h:383:8: note: ‘struct CHARSET_INFO’ declared here 383 | struct CHARSET_INFO { | ^~~~~~~~~~~~ [2]: strings/conf_to_src.cc: In function ‘int main(int, char**)’: strings/conf_to_src.cc:292:9: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct CHARSET_INFO’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess] 292 | memset(&ncs, 0, sizeof(ncs)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~ In file included from strings/conf_to_src.cc:32: include/m_ctype.h:383:8: note: ‘struct CHARSET_INFO’ declared here 383 | struct CHARSET_INFO { | ^~~~~~~~~~~~ [3]: 02369bd
laurynas-biveinis
force-pushed
the
llvm-18-fixes
branch
from
5c3892e to
385fb4e
Compare
Contributor
Author
|
Forgot to reset the Draft state of this PR :( It is ready for review |
bladepan
reviewed
Oct 22, 2024
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 69710da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of memset'ing it to zero, fixing [1]
default-initialized to zero, fixing [2]
Squash with 6637b51
[1]:
strings/ctype.cc: In function ‘void my_charset_file_reset_charset(MY_CHARSET_FILE*)’:
strings/ctype.cc:303:9: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct CHARSET_INFO’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
303 | memset(&i->cs, 0, sizeof(i->cs));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from strings/ctype.cc:36:
include/m_ctype.h:383:8: note: ‘struct CHARSET_INFO’ declared here
383 | struct CHARSET_INFO {
| ^~~~~~~~~~~~
[2]:
strings/conf_to_src.cc: In function ‘int main(int, char**)’:
strings/conf_to_src.cc:292:9: error: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct CHARSET_INFO’ with no trivial copy-assignment; use value-initialization instead [-Werror=class-memaccess]
292 | memset(&ncs, 0, sizeof(ncs));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from strings/conf_to_src.cc:32:
include/m_ctype.h:383:8: note: ‘struct CHARSET_INFO’ declared here
383 | struct CHARSET_INFO {
| ^~~~~~~~~~~~