Move MyRocks sysvars to sysvars.cc and sysvars.h #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce new source files sysvars.cc and sysvars.h and move there everything related to MyRocks system variables. Modernize them (NULL -> nullptr, drop unused args instead of MY_ATTRIBUTE((unused)), drop redundant struct keywords, Almost Always Auto, C-style casts -> static_cast, etc.) - Introduce new namespace myrocks::sysvars for the variables and their trivial getters, drop "rocksdb_" prefixes except where it is needed to avoid confusion (i.e. datadir). - For non-trivial MyRocks/RocksDB operations that need to be done from sysvar validate/set functions, expose them through ha_rocksdb.h as needed. - Convert myrocks::get_rocksdb_db_options to return a reference instead of a pointer. - Fix some typos while reflowing the sysvar descriptions, re-record main.mysqld--help-notwin accordingly.
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing. |
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to MyRocks system variables. Modernize them (NULL -> nullptr, drop
unused args instead of MY_ATTRIBUTE((unused)), drop redundant struct keywords,
Almost Always Auto, C-style casts -> static_cast, etc.)
getters, drop "rocksdb_" prefixes except where it is needed to avoid
confusion (i.e. datadir).
validate/set functions, expose them through ha_rocksdb.h as needed.
pointer.
main.mysqld--help-notwin accordingly.