This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Skip drop system tables during clone drop user data#1501
Closed
luqun wants to merge 1 commit into
Closed
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Summary:
Skip drop system tables during clone drop user data
For MyRocks DDSE, its system table doesn't have valid tablespace id, thus these system tables(such as mysql.user) in the recipient instance will be droped during drop user data stage. if at same time, some automations may check the instance and found out the instance doesn't have these important tables.
The change is to use table name to check whether these table are DD/systems tables
PR:#1501
fbshipit-source-id: 75a97f523d25f14d524a782e38dc2836557c8ed8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For MyRocks DDSE, its system table doesn't have valid tablespace id, thus these system tables(such as mysql.user) in the recipient instance will be droped during drop user data stage. if at same time, some automations may check the instance and found out the instance doesn't have these important tables.
The change is to use table name to check whether these table are DD/systems tables