Introduce rdb_snapshot_unique_ptr & make rdb_get_rocksdb_db return reference #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurynas-biveinis
force-pushed
the
cleanup-rdb-snapshots
branch
from
5c5c2ae to
a9afc5c
Compare
Contributor
Author
|
Needs rebasing |
…ference This is a second batch of cleanups from the repeatable read snapshot work. - Make rdb_get_rocksdb_db return reference instead of pointer, update callers and callees. Inline this function in ha_rocksdb_proto.h, move rdb declaration there to support inlining in detail namespace as documentation that it should not be accessed directly. Update ha_rocksdb.cc itself to use rdb_get_rocksdb_db instead of rdb. Remove many redudant rdb != nullptr checks and asserts. - Introduce rdb_snapshot_unique_ptr with a custom deleter and a factory function get_rdb_snapshot to manager global RocksDB snapshots - Make Rdb_explicit_snapshot create the snapshot itself, by calling get_rdb_snapshot, instead of receiving one through parameters, simplify its signature. - Replace rocksdb::ManagedSnapshot uses with rdb_snapshot_unique_ptr ones. - Remove rarely-used explicit transaction snapshot assignment code from acquire_snapshot and move it to the few callers where it may happen. Add new method Rdb_transaction::has_explicit_or_read_only_snapshot to support this. - For Rdb_transaction, make m_insert_count, m_update_count, m_delete_count, m_auto_incr_map, & m_rollback_only fields private instead of protected. Move their reset at the end of committed or rolledback transactions to on_finish method in the base class. Remove redundant m_writes_at_last_savepoint reset in set_initial_savepoint. - Add several asserts.
laurynas-biveinis
force-pushed
the
cleanup-rdb-snapshots
branch
from
a9afc5c to
2f76458
Compare
Contributor
Author
|
@luqun , rebased & ready for review |
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second batch of cleanups from the repeatable read snapshot work.
and callees. Inline this function in ha_rocksdb_proto.h, move rdb declaration
there to support inlining in detail namespace as documentation that it should
not be accessed directly. Update ha_rocksdb.cc itself to use
rdb_get_rocksdb_db instead of rdb. Remove many redudant rdb != nullptr checks
and asserts.
get_rdb_snapshot to manager global RocksDB snapshots
get_rdb_snapshot, instead of receiving one through parameters, simplify its
signature.
acquire_snapshot and move it to the few callers where it may happen.
Add new method Rdb_transaction::has_explicit_or_read_only_snapshot to support
this.
m_auto_incr_map, & m_rollback_only fields private instead of protected. Move
their reset at the end of committed or rolledback transactions to on_finish
method in the base class. Remove redundant m_writes_at_last_savepoint reset in
set_initial_savepoint.