This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Add stall counters to 'SHOW GLOBAL STATUS' output.#695
Closed
Tema wants to merge 10 commits into
Closed
Conversation
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
There was a problem hiding this comment.
1st arg: const ref, 2nd arg: rvalue ref?
Author
There was a problem hiding this comment.
Sure. Not sure how to make a const, though, as I use iterator inside.
Author
There was a problem hiding this comment.
Ok, I think I've figured out how to do that in my latest revision. Thanks.
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hermanlee
suggested changes
Sep 1, 2017
Contributor
There was a problem hiding this comment.
This can probably be a const std::string &key I think. There's probably no need for this to be a &&.
Contributor
There was a problem hiding this comment.
Initializing io_stall_stats and then adding counters to it might cause strange behavior if the command is run concurrently. It might be better to not initialize io_stall_stats and set the members equal to the value returned by rocksdb, similar to the other status variables in memory_usage or export stats.
Author
There was a problem hiding this comment.
It is a bit different than memory_usage or export stats methods as I need to loop through multiple calls to accumulate the final result. But I see you concern, so I can create a local struct then copy it to the global one at the end of method call.
Contributor
There was a problem hiding this comment.
I think this can just be const std::string &key.
Author
There was a problem hiding this comment.
Not sure if it possible as I pass a string directly to the method call, like
io_stall_stats.level0_slowdown += io_stall_prop_value(props, "level0_slowdown");
LMK if I miss something.
Contributor
There was a problem hiding this comment.
I tested this before when I saw your call with arguments like "level0_slowdown" and it looks to work with const std::string &key. Not clear to me if there is preference for one or the other.
Author
There was a problem hiding this comment.
I've tested it again and it turned out my original test missed 'const'. If I use it then it works indeed. I will change it according to your comment.
Contributor
There was a problem hiding this comment.
What additional keys are returned when switching to the string version of GetMapProperty? The information schema table is still returning a double though, so the additional keys would need to have values that are doubles, which seems odd that they're not returned by the double version of GetMapProperty in the first place.
Author
There was a problem hiding this comment.
Now all keys are returned with some prefixes. The old values now have "compaction." key prefix and new ones have "io_stalls." prefix. This method now skips keys with prefixes other than "compaction."
I've tested INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS table and see that it contains the same data it contained before.
Contributor
There was a problem hiding this comment.
What would be returned in I_S.COMPACTION_STATS without this change? Does calling GetMapProperty() using std::map<std::string, std::double> not return all of the keys with "compaction." key prefix?
Author
There was a problem hiding this comment.
I've updated summary to highlight what rocksdb changes were done relevant to this PR.
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hermanlee
approved these changes
Sep 8, 2017
Contributor
There was a problem hiding this comment.
Since this doesn't change, can probably declare this outside the for loop and make it const.
Contributor
There was a problem hiding this comment.
Did you intend to remove the true indicating the value is unsigned?
Author
There was a problem hiding this comment.
Yes, the overridden method with boolean accept longlong but the value we pass is actually double. Essentially this diff fixes a bug here. Please see a Test Plan note in "Check that compaction level metrics are still published to
INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly including real double values" section where previously the Score was displayed as 0 and now it is 0.25.
Contributor
There was a problem hiding this comment.
If there are non-deterministic results from this query, you can add an order by clause to this select.
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Tema
force-pushed
the
io_stall_stats
branch
from
f4dbdb4 to
1bfe8a3
Compare
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Tema
force-pushed
the
io_stall_stats
branch
from
1bfe8a3 to
aae1c20
Compare
|
@Tema updated the pull request - view changes - changes since last import |
|
@Tema has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 27, 2017
Upstream commit ID : fb-mysql-5.6.35/3f9ff433589a3ab5cb94e249fa649835ee077321 Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 21b4c50
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 27, 2017
Upstream commit ID : fb-mysql-5.6.35/3f9ff433589a3ab5cb94e249fa649835ee077321 Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 21b4c50
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 30, 2017
Upstream commit ID : fb-mysql-5.6.35/3f9ff433589a3ab5cb94e249fa649835ee077321 Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 21b4c50
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 31, 2017
Upstream commit ID : fb-mysql-5.6.35/3f9ff433589a3ab5cb94e249fa649835ee077321 Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 21b4c50
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Nov 1, 2017
Upstream commit ID : fb-mysql-5.6.35/3f9ff433589a3ab5cb94e249fa649835ee077321 Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 21b4c50
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2019
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes #695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 12, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Test Plan: * Check that compaction level metrics are still published to INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly * Check the output of the command: ``` mysql> show status like 'rocksdb_stall_%'; +-----------------------------------------------------+-------+ | Variable_name | Value | +-----------------------------------------------------+-------+ | rocksdb_stall_level0_slowdown | 2 | | rocksdb_stall_level0_slowdown_with_compaction | 4 | | rocksdb_stall_level0_numfiles | 10 | | rocksdb_stall_level0_numfiles_with_compaction | 12 | | rocksdb_stall_stop_for_pending_compaction_bytes | 16 | | rocksdb_stall_slowdown_for_pending_compaction_bytes | 14 | | rocksdb_stall_memtable_compaction | 6 | | rocksdb_stall_memtable_slowdown | 8 | | rocksdb_stall_total_count | 56 | | rocksdb_stall_micros | 0 | +-----------------------------------------------------+-------+ ``` (In order to have some non-zero numbers, I've initialized internal RocksDB stall stats with 1-8 numbers. They all doubled in output as there are two column families in my instance: default and system. The stall_micros has been introduced previously. total_count doesn't include level0_slowdown_with_compaction and numfiles_with_compaction as only their total counterparts are included in this counter.) Differential Revision: D5723305 Pulled By: Tema fbshipit-source-id: 1977338
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes #695 Differential Revision: D5723305 (3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 31, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
…cebook#695) Summary: update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 (facebook@3f9ff43) Pulled By: Tema fbshipit-source-id: 688fb48f15f
hermanlee
pushed a commit
that referenced
this pull request
Jan 10, 2022
Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes #695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…cona#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 23, 2022
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
laurynas-biveinis
pushed a commit
to laurynas-biveinis/mysql-5.6
that referenced
this pull request
Aug 11, 2022
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 25, 2023
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…cebook#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook#695 Differential Revision: D5723305 Pulled By: Tema
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…cona#695) Summary: @update-submodule: rocksdb The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS output' but this command is a bit expensive to run and you have to parse the output to monitor these values. This branch adds these counters to structured output of SHOW GLOBAL STATUS command. Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float. The rocksdb module was updated to bring [this](facebook/rocksdb#2794 (review)) change which has the following changes to GetMapProperty method: 1. Changed values from double to string 2. Change existing keys to start with "compaction." prefix for all keys returned by old version of GetMapProperty. 3. Added stall values with keys starting with "io_stall." prefix Closes facebook/mysql-5.6#695 Differential Revision: D5723305 Pulled By: Tema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@update-submodule: rocksdb
Summary:
The stall counters are already shown in 'SHOW ENGINE ROCKSDB STATUS
output' but this command is a bit expensive to run and you have to parse
the output to monitor these values. This branch adds these counters to
structured output of SHOW GLOBAL STATUS command.
Also fixed the bug in INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS which showed only integer values but not float.
The rocksdb module was updated to bring this change which has the following changes to GetMapProperty method:
Test plan:
INFORMATION_SCHEMA.ROCKSDB_COMPACTION_STATS properly including real double values.
BEFORE:
| system | L0 | Rnp1GB | 0 |
| system | L0 | Score | 0 |
| system | L0 | SizeBytes | 1433 |
AFTER:
| system | L0 | Rnp1GB | 0 |
| system | L0 | Score | 0.25 |
| system | L0 | SizeBytes | 1433 |
(In order to have some non-zero numbers, I've initialized internal
RocksDB stall stats with 1-8 numbers. They all doubled in output as
there are two column families in my instance: default and system.
The stall_micros has been introduced previously. total_count doesn't
include level0_slowdown_with_compaction and numfiles_with_compaction
as only their total counterparts are included in this counter.)