optimize lz matchfinding loop (#826)#826
Closed
Victor-C-Zhang wants to merge 1 commit into
Closed
Conversation
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109051308. |
Summary: This is v2 of D108382572. During testing, it was discovered that an optimized scalar loop (this diff) was equal to, and in some cases faster than a vectorized implementation, on both x86 and arm. This diff makes this change and leaves a marker for future contributors interested in optimizing the LZ kernels. To future contributors: the code attached in D108382572 is neutral to slightly worse on Skylake, Bergamo, and Turin, and significantly worse on Grace. However, this is not a universal fact across the test corpus, where individual file variation is sometimes +/-5% on *total* compression speed. This likely depends on the data being compressed, but for the general case, it's worse. Reviewed By: terrelln Differential Revision: D109051308
Victor-C-Zhang
force-pushed
the
export-D109051308
branch
from
b6a8d8a to
b841fa1
Compare
|
This pull request has been merged in ea4e4e3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is v2 of D108382572. During testing, it was discovered that an optimized scalar loop (this diff) was equal to, and in some cases faster than a vectorized implementation, on both x86 and arm. This diff makes this change and leaves a marker for future contributors interested in optimizing the LZ kernels.
To future contributors: the code attached in D108382572 is neutral to slightly worse on Skylake, Bergamo, and Turin, and significantly worse on Grace. However, this is not a universal fact across the test corpus, where individual file variation is sometimes +/-5% on total compression speed. This likely depends on the data being compressed, but for the general case, it's worse.
Reviewed By: terrelln
Differential Revision: D109051308