Add components tests (#828)#828
Open
jlee303 wants to merge 4 commits into
Open
Conversation
|
@jlee303 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108981254. |
Summary: Pull Request resolved: facebook#824 Expanded existing streamdump visualizer tests, added codecdag/chunk graph tests. Fixed bug in function graph expands so that diamond shaped graphs will work as expected. - Include all parents when expanding/collapsing graph - Updated visited set - Updated buck so that tests actually run in diff Differential Revision: D108782795
Summary: Pull Request resolved: facebook#827 - Add unit tests for StreamdumpGraphController and LayoutController. - Add shared test helpers in mockGraphNodes.ts and updated createTestModels.ts fixture to expose underlying raw Streamdump Differential Revision: D108940518
Differential Revision: D109043852
Summary: Pull Request resolved: facebook#828 - Add tests case to verify components (app, toolbar, settings) appear and work as expected - Verify settings is updated when user toggles keyboard or trackpad mode - Verify that cbor file is decoded when passed in - Fixed small bug where wrong api references page was included in toolbar Differential Revision: D108981254
jlee303
force-pushed
the
export-D108981254
branch
from
d4c159f to
76a7bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D108981254