dict training deduplication and bundle info#832
Closed
Victor-C-Zhang wants to merge 1 commit into
Closed
Conversation
Summary: Add deduplication for trained dictionaries and bundle info packing support to the OpenZL training infrastructure. base_dict_trainer.cpp: - Add DictIDCmp comparator for ZL_DictID to enable std::set usage with bytewise comparison. - Track unique dict IDs during training to skip duplicate dictionaries. When a generated dict ID already exists in the set, the duplicate is skipped since OpenZL dict loading will materialize it properly from the existing entry. trained_candidate.cpp/h: - Add packBundleInfo() method to pack standalone bundle metadata without appending dict contents. Creates a ZL_BundleInfo structure with bundle ID, dict IDs, and packs it using BundleInfo_pack(). Reviewed By: daniellerozenblit Differential Revision: D108207923
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108207923. |
|
This pull request has been merged in 77939b1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add deduplication for trained dictionaries and bundle info packing support to the OpenZL training infrastructure.
base_dict_trainer.cpp:
trained_candidate.cpp/h:
Reviewed By: daniellerozenblit
Differential Revision: D108207923