C++: Use New & Improved Translation of Exceptions to ZL_Errors (#838)#838
Closed
terrelln wants to merge 5 commits into
Closed
C++: Use New & Improved Translation of Exceptions to ZL_Errors (#838)#838terrelln wants to merge 5 commits into
terrelln wants to merge 5 commits into
Conversation
Summary: As title. Differential Revision: D101645553
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Differential Revision: D101645608
Summary: This is more general and simpler than `getErrorContextString()`, which has side-effects. This diff also implements `ZL_OC_getErrorContextString()` in terms of `ZL_OC_findError()`. Differential Revision: D101645669
Summary: This will be useful when shoving C++ stuff into the OpenZL core. Differential Revision: D101645708
|
@terrelln has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101645755. |
…ook#838) Summary: Pull Request resolved: facebook#838 Pull Request resolved: facebook#709 As title. Reviewed By: mmandina Differential Revision: D101645755
terrelln
force-pushed
the
export-D101645755
branch
from
641394a to
6ed9a5e
Compare
meta-codesync
Bot
changed the title
|
This pull request has been merged in ee548a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
Reviewed By: mmandina
Differential Revision: D101645755