Disallow member access on scan records#854
Closed
daniellerozenblit wants to merge 2 commits into
Closed
Conversation
Summary: ## Stack The goal of this stack is to support scan records in SDDL2. ## Diff This diff introduces classification of records as either "instant-parse" or "requires-scan" based on whether their layout depends on their own field values. Reviewed By: terrelln Differential Revision: D105572482
Summary: Adds a check in the SemanticAnalyzer to reject member access on records whose layout cannot be determined without scanning the input (`requires_scan == true`). Reviewed By: terrelln Differential Revision: D105966083
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105966083. |
|
This pull request has been merged in e778a89. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adds a check in the SemanticAnalyzer to reject member access on records whose layout cannot be determined without scanning the input (
requires_scan == true).Reviewed By: terrelln
Differential Revision: D105966083