Let unused-ignore in a suppression opt out of unused-ignore reporting#3957
Open
kz357 wants to merge 1 commit into
Open
Let unused-ignore in a suppression opt out of unused-ignore reporting#3957kz357 wants to merge 1 commit into
unused-ignore in a suppression opt out of unused-ignore reporting#3957kz357 wants to merge 1 commit into
Conversation
A `# pyrefly: ignore[...]` comment that lists `unused-ignore` is now not itself reported as unused, and listing it suppresses the unused-ignore diagnostic for that comment. This lets a single comment cover code that errors on one Python vrsion but not another (used on one, unused on other) without dead-ending, matching mypy/ty. Normal unused comment that doesn't explicitly list `unused-ignore` is still reported. Fixes facebook#3951
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
# pyrefly: ignore[...]comment that listsunused-ignoreis now not itself reported as unused, and listing it suppresses the unused-ignore diagnostic for that comment. This lets a single comment cover code that errors on one Python version but not another (used on one, unused on other) without dead-ending, matching mypy/ty.Normal unused comment that doesn't explicitly list
unused-ignoreis still reported.Fixes #3951
Test Plan
4 unit tests in pyrefly/lib/state/errors.rs
cargo test -p pyrefly --lib unused_ignore[unused-ignore]doesn't self-flagcargo fmt and cargo clippy run fine