Support bare factory-boy factory calls returning the model type#3961
Open
ak4-sh wants to merge 1 commit into
Open
Support bare factory-boy factory calls returning the model type#3961ak4-sh wants to merge 1 commit into
ak4-sh wants to merge 1 commit into
Conversation
Calling a DjangoModelFactory subclass directly (`UserFactory()`) is equivalent to `UserFactory.create()` at runtime via FactoryMetaClass, but Pyrefly typed it as an instance of the factory rather than the model, producing false missing-attribute errors on every field access. Add tests to confirim correct behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a DjangoModelFactory subclass directly (
UserFactory()) is equivalent toUserFactory.create()at runtime via FactoryMetaClass, but Pyrefly typed it as an instance of the factory rather than the model, producing false missing-attribute errors on every field access.Add tests to confirim correct behaviour
Fixes #3934
Test Plan
Add 2 tests: