fix Feature suggestion: special case _replace in NamedTuple #3960#3971
Open
asukaminato0721 wants to merge 1 commit into
Open
fix Feature suggestion: special case _replace in NamedTuple #3960#3971asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
|
Diff from mypy_primer, showing the effect of this PR on open source code: pip (https://github.com/pypa/pip)
+ ERROR src/pip/_vendor/requests/sessions.py:232:51-68: Argument `bytes | str` is not assignable to parameter `fragment` with type `str` in function `urllib.parse.ParseResult._replace` [bad-argument-type]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3960
Implemented synthesized
_replacesupport for NamedTuple, static named tuples now get optional keyword-only params typed from their fields,reject unknown kwargs, reject positional replacements, and return Self.
Dynamic-field named tuples keep permissive
**kwargs: Any.Test Plan
add test