Flush option in WaitForCompact()

[jaykorean]

Context:

As mentioned in #11436, introducing flush option in WaitForCompactOptions to flush before waiting for compactions to finish. Must be set to true to ensure no immediate compactions (except perhaps periodic compactions) after closing and re-opening the DB.

Summary

1. bool flush = false added to WaitForCompactOptions
2. DBImpl::FlushAllColumnFamilies() is introduced and DBImpl::FlushForGetLiveFiles() is refactored to call it.
3. DBImpl::FlushAllColumnFamilies() gets called before waiting in WaitForCompact() if flush option is true
4. Some previous WaitForCompact tests were parameterized to include both cases for abort_on_pause_ being true/false as well as flush_ being true/false

Test Plan

• DBCompactionTest::WaitForCompactWithOptionToFlush added
• Changed existing DBCompactionTest::WaitForCompact tests to DBCompactionWaitForCompactTest to include params

[facebook-github-bot]

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cbi42]

DBImpl::GetLiveFiles() is refactored to call it

Nit: in PR summary, do you mean DBImpl::FlushForGetLiveFiles instead? Or we can get rid of FlushForGetLiveFiles and just call FlushAllColumnFamilies() in DBImpl::GetLiveFiles().

[facebook-github-bot]

@jaykorean has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[pdillinger]

Awesome! Thanks!

[facebook-github-bot]

@jaykorean merged this pull request in 87bc929.