Fix the bloom filter true positive stat in async MultiGet#11500
Open
anand1976 wants to merge 1 commit into
Open
Fix the bloom filter true positive stat in async MultiGet#11500anand1976 wants to merge 1 commit into
anand1976 wants to merge 1 commit into
Conversation
Contributor
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pdillinger
reviewed
Jun 2, 2023
Contributor
There was a problem hiding this comment.
This is difficult to follow, as nothing seems to reliably mean quite what it's supposed to mean. E.g. somehow skip_range_deletions works for the filter_matched parameter (I found why in version_set.cc), except it might need to be fixed up in some cases.
How about enum FilteringResponsibility { kCallerFilter, kSkipFilter, kCalleeFilter } to replace the two boolean parameters. The final if condition would be matched && (filter != null || (filtering_responsibility == kCallerFilter && rep_->filter)) or equivalently (better) matched && filtering_responsibility != kSkipFilter && rep_->filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stat was broken for the async IO flavor of MultiGet after #10432. Now, we pass a flag to the TableReader MultiGet to indicate whether filter lookup was already done or not. If the flag is true, then the stat is updated.