rocksdb/db.h: GetDbIdentity comment: ID comes from MANIFEST

[evanj]

Commit 98c33cb changed the default for the write_dbid_to_manifest option, so this ID now comes from MANIFEST and not IDENTITY. Update the comment to reflect that.

Remove 2 unneeded words from the comment on GetDbSessionId since it refers to this function.

[evanj]

Rebased on main still relevant.

[github-actions]

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

[github-actions]

✅ Claude Code Review

Auto-triggered after CI passed — reviewing commit e470c39

---

Review Findings: rocksdb/db.h: GetDbIdentity comment: ID comes from MANIFEST

PR: GetDbIdentity comment update | Author: evanj | Scope: 1 file, 4 insertions, 4 deletions — comments only

Summary

This PR updates two comments in include/rocksdb/db.h:

1. GetDbIdentity: Updates the comment to reflect that the DB unique ID now comes from the MANIFEST file (not the IDENTITY file), and references the write_dbid_to_manifest option.
2. GetDbSessionId: Removes two unnecessary words ("other function") from the parenthetical referencing GetDbIdentity.

Verification

• write_dbid_to_manifest defaults to true: Confirmed at include/rocksdb/options.h:1524
• Option docs at options.h:1514-1523 describe MANIFEST as "preferred" and IDENTITY as "historical, deprecated"
• GetDbIdentity impl at db/db_impl/db_impl.cc:5663 returns db_id_, set during open from MANIFEST or IDENTITY

Findings

No issues found. This is a correct, minimal documentation-only change.

Category	Assessment
Factual accuracy	Correct
API compatibility	No changes
Style	Improved clarity

Verdict: LGTM.

---

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

• Claude may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /claude-review [context] — Request a code review
• /claude-query <question> — Ask about the PR or codebase