Add Safeguard around compaction stats cpu micros#13799
Draft
jaykorean wants to merge 1 commit into
Draft
Conversation
jaykorean
force-pushed
the
safeguard_compaction_cpu_micros_stats
branch
from
b5f47a4 to
f1e734e
Compare
jaykorean
force-pushed
the
safeguard_compaction_cpu_micros_stats
branch
from
f1e734e to
9a3829a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We've observed a negative value reported for
compaction_job_stats.cpu_micros. Adding an assertion to check if this can be caught by the stress test, along with some safeguards to prevent negative values from being set.Test Plan