Fix null pointer crash in WriteUnpreparedTxn::GetIterator#14459
Open
omkarhgawde wants to merge 1 commit into
Open
Fix null pointer crash in WriteUnpreparedTxn::GetIterator#14459omkarhgawde wants to merge 1 commit into
omkarhgawde wants to merge 1 commit into
Conversation
Summary: `WriteUnpreparedTxnDB::NewIterator()` can return nullptr when `largest_validated_seq_` exceeds the snapshot sequence and `unprep_seqs_` is non-empty. The caller `WriteUnpreparedTxn::GetIterator()` only guards against this with `assert(db_iter)`, which is a no-op in release builds. The null pointer is then passed to `NewIteratorWithBase()`, causing a crash. Fix: Add an explicit null check and return a NewErrorIterator with a Corruption status. Differential Revision: D95303545
|
@omkarhgawde has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95303545. |
✅ clang-tidy: No findings on changed linesCompleted in 106.1s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
WriteUnpreparedTxnDB::NewIterator()can return nullptr whenlargest_validated_seq_exceeds the snapshot sequence andunprep_seqs_is non-empty. The caller
WriteUnpreparedTxn::GetIterator()only guardsagainst this with
assert(db_iter), which is a no-op in release builds.The null pointer is then passed to
NewIteratorWithBase(), causing a crash.Fix: Add an explicit null check and return a NewErrorIterator with a
Corruption status.
Differential Revision: D95303545