Keep remote compaction stats serialization compatible with 11.1#14712
Closed
xingbowang wants to merge 1 commit into
Closed
Keep remote compaction stats serialization compatible with 11.1#14712xingbowang wants to merge 1 commit into
xingbowang wants to merge 1 commit into
Conversation
Reapply c494176 so remote compaction serializes InternalStats::CompactionStats::counts with the pre-11.2 compaction-reason count. Using the full 11.2 CompactionReason range changes the serialized array length, which breaks compatibility with 11.1 readers and writers. Keep the temporary 11.1-compatible size until the stats serialization path has version-aware array handling.
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D104130456. |
✅ clang-tidy: No findings on changed linesCompleted in 40.2s. |
joshkang97
approved these changes
May 6, 2026
joshkang97
left a comment
joshkang97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@xingbowang merged this pull request in e0d549f. |
xingbowang
added a commit
to xingbowang/rocksdb
that referenced
this pull request
May 7, 2026
…book#14712) Summary: - Reapply c494176 so remote compaction serializes InternalStats::CompactionStats::counts with the pre-11.2 compaction-reason count. - Keep remote compaction result metadata compatible with 11.1 readers and writers until the stats serialization path has version-aware array handling. Pull Request resolved: facebook#14712 Test Plan: - make format-auto - make -j$(sysctl -n hw.ncpu) compaction_job_test compaction_service_test - /usr/local/bin/timeout 60 ./compaction_job_test --gtest_filter=CompactionJobTest.ResultSerialization - /usr/local/bin/timeout 60 ./compaction_service_test --gtest_filter=CompactionServiceTest.VerifyStats Reviewed By: joshkang97, jaykorean Differential Revision: D104130456 Pulled By: xingbowang fbshipit-source-id: e9e92cb044253edbec0fc79b92c3efff53f01d8b
xingbowang
added a commit
to xingbowang/rocksdb
that referenced
this pull request
May 7, 2026
…book#14712) Summary: - Reapply c494176 so remote compaction serializes InternalStats::CompactionStats::counts with the pre-11.2 compaction-reason count. - Keep remote compaction result metadata compatible with 11.1 readers and writers until the stats serialization path has version-aware array handling. Pull Request resolved: facebook#14712 Test Plan: - make format-auto - make -j$(sysctl -n hw.ncpu) compaction_job_test compaction_service_test - /usr/local/bin/timeout 60 ./compaction_job_test --gtest_filter=CompactionJobTest.ResultSerialization - /usr/local/bin/timeout 60 ./compaction_service_test --gtest_filter=CompactionServiceTest.VerifyStats Reviewed By: joshkang97, jaykorean Differential Revision: D104130456 Pulled By: xingbowang fbshipit-source-id: e9e92cb044253edbec0fc79b92c3efff53f01d8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: