Add file ingestion histograms#14833
Closed
joshkang97 wants to merge 1 commit into
Closed
Conversation
Summary: Adds a public `Statistics` histogram, `INGEST_EXTERNAL_FILE_TIME` (`"rocksdb.ingest.external.file.micros"`), recording the end-to-end latency in microseconds of each `IngestExternalFile(s)` call. Ingestion timing was previously only available through per-thread `perf_context` counters, which require setting a `PerfLevel` and are not aggregated, so there was no process-wide latency distribution (p50/p99/max) for dashboards. It is recorded with an RAII `StopWatch` at the top of `DBImpl::IngestExternalFiles` -- one sample per call (not per column family), covering all return paths. It is null-safe and self-gating on the stats level, so there is no cost when statistics are off, and ingestion is not a hot path. Java bindings are kept in sync per the `statistics.h` requirement; the C API needs no change. Reviewed By: xingbowang Differential Revision: D107721260
|
@joshkang97 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107721260. |
✅ clang-tidy: No findings on changed linesCompleted in 277.3s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a public
Statisticshistogram,INGEST_EXTERNAL_FILE_TIME("rocksdb.ingest.external.file.micros"), recording the end-to-end latency in microseconds of eachIngestExternalFile(s)call. Ingestion timing was previously only available through per-threadperf_contextcounters, which require setting aPerfLeveland are not aggregated, so there was no process-wide latency distribution (p50/p99/max) for dashboards.It is recorded with an RAII
StopWatchat the top ofDBImpl::IngestExternalFiles-- one sample per call (not per column family), covering all return paths. It is null-safe and self-gating on the stats level, so there is no cost when statistics are off, and ingestion is not a hot path. Java bindings are kept in sync per thestatistics.hrequirement; the C API needs no change.Reviewed By: xingbowang
Differential Revision: D107721260