Skip to content

Add C API bindings for manifest and file size tuning options#14848

Open
dheerajd5 wants to merge 1 commit into
facebook:mainfrom
dheerajd5:manifest-file-sizing-c-api
Open

Add C API bindings for manifest and file size tuning options#14848
dheerajd5 wants to merge 1 commit into
facebook:mainfrom
dheerajd5:manifest-file-sizing-c-api

Conversation

@dheerajd5

@dheerajd5 dheerajd5 commented Jun 11, 2026

Copy link
Copy Markdown

Summary

This PR is to fix issue : #14285

  • Expose max_manifest_space_amp_pct and target_file_size_is_upper_bound to the C API.

    • rocksdb_options_set_max_manifest_space_amp_pct takes in int
    • rocksdb_options_get_max_manifest_space_amp_pct returns int
    • rocksdb_options_set_target_file_size_is_upper_bound takes in unsigned char
    • rocksdb_options_get_target_file_size_is_upper_bound returns unsigned char
  • Allows C API users to have more finer grained control over manifest and SST file sizings.

Test Plan

  • Tests are added to c_test , under "options" , to validate getter and setters for the two fields.
@meta-cla meta-cla Bot added the CLA Signed label Jun 11, 2026
@dheerajd5 dheerajd5 force-pushed the manifest-file-sizing-c-api branch from ac97564 to f201108 Compare June 13, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant