fix package fault injection log parser in db stress fbpkg (#14874)

[mszeszko-meta]

Problem

RocksDB alert fired after the job started crashlooping with ModuleNotFoundError: No module named fault_injection_log_parser.

RCA

#14651 added import fault_injection_log_parser to db_crashtest.py, but rocksdb_db_stress only packaged crashtest.py and rocks_db_stress, so the release_test fbpkg rolled to TW without the new helper module.

Fix

Export tools/fault_injection_log_parser.py and include it in the rocksdb_db_stress fbpkg path_actions so it is installed next to crashtest.py.

Reviewed By: xingbowang

Differential Revision: D109346224

[meta-codesync]

@mszeszko-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109346224.

[github-actions]

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

[github-actions]

🟡 Codex Code Review

Auto-triggered after CI passed — reviewing commit 24ec993

---

❌ Codex review failed before producing findings.

WARNING: proceeding, even though we could not create PATH aliases: Refusing to create helper binaries under temporary dir "/tmp" (codex_home: AbsolutePathBuf("/tmp/codex-home"))
error: the argument '--base <BRANCH>' cannot be used with '[PROMPT]'

Usage: codex exec review --commit <SHA> --base <BRANCH> --title <TITLE> --model <MODEL> --config <key=value> --dangerously-bypass-approvals-and-sandbox --output-last-message <FILE> [PROMPT]

For more information, try '--help'.

---

ℹ️ About this response

Generated by Codex CLI.
Review methodology: claude_md/code_review.md

Limitations:

• Codex may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /codex-review [context] — Request a code review
• /codex-query <question> — Ask about the PR or codebase

[github-actions]

✅ Claude Code Review

Auto-triggered after CI passed — reviewing commit 24ec993

---

Summary

Correct and minimal fix for a packaging bug. The PR adds the missing fault_injection_log_parser.py module to the BUCK build so it ships alongside db_crashtest.py, which imports it. The change follows the exact same pattern as the existing db_crashtest.py export.

No high-severity findings.

Full review (click to expand)

Findings

🟢 LOW / NIT

No issues found. The change is correct.

Verification

Check	Result
tools/fault_injection_log_parser.py exists	YES
db_crashtest.py imports fault_injection_log_parser	YES (bare import fault_injection_log_parser)
export_file pattern matches existing db_crashtest.py export	YES (identical pattern)
Placement in buckify_rocksdb.py is correct (after existing export)	YES (line 363, right after db_crashtest.py export on line 362)
Any other non-stdlib imports missing from BUCK	NO — fault_injection_log_parser is the only non-stdlib import
BUCK file updated both manually and in generator	YES — both BUCK and buckify_rocksdb.py updated consistently

Positive Observations

• The fix is minimal and surgical — exactly the two lines needed.
• Both the generated BUCK file and the generator script (buckify_rocksdb.py) are updated, keeping them in sync per CLAUDE.md guidelines.
• The export_file call uses the same naming convention (tools/ prefix) as the existing export.

---

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

• Claude may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /claude-review [context] — Request a code review
• /claude-query <question> — Ask about the PR or codebase

[meta-codesync]

This pull request has been merged in 30f42e0.