Skip to content

fix build bug#48

Merged
igorcanadi merged 3 commits into
facebook:masterfrom
dyu:master
Jan 2, 2014
Merged

fix build bug#48
igorcanadi merged 3 commits into
facebook:masterfrom
dyu:master

Conversation

@dyu

@dyu dyu commented Dec 27, 2013

Copy link
Copy Markdown
Contributor

The bug was introduced from fix build bug from the recent commit: 43c386b

@vmg

vmg commented Dec 27, 2013

Copy link
Copy Markdown

Bumping this. 43c386b from @jamesgolick breaks the build on Linux when fallocate is actually present. The right fix would be as follows:

COMMON_FLAGS="$COMMON_FLAGS -DROCKSDB_FALLOCATE_PRESENT"
@dyu

dyu commented Dec 27, 2013

Copy link
Copy Markdown
Contributor Author

@vmg's fix is the correct one.

@yadvr

yadvr commented Jan 2, 2014

Copy link
Copy Markdown

Thanks for the fix 👍 I was about to open a pull request on the same :)

ajkr pushed a commit to ajkr/rocksdb that referenced this pull request Sep 13, 2019
…t-add-ordering-check

[2.1 backport] table: Always check key ordering when inserting to an SST
Little-Wallace pushed a commit to Little-Wallace/rocksdb that referenced this pull request Sep 3, 2021
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Initial 0.11 compatibility attempt, using new project: NAN
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants