Skip to content

InlineSkipList to reduce binary search when repeatly seeking to the same position#5316

Open
siying wants to merge 2 commits into
facebook:mainfrom
siying:skiplist_reseek2
Open

InlineSkipList to reduce binary search when repeatly seeking to the same position#5316
siying wants to merge 2 commits into
facebook:mainfrom
siying:skiplist_reseek2

Conversation

@siying

@siying siying commented May 16, 2019

Copy link
Copy Markdown
Contributor

Summary: It's not uncommon for memtable reseek to end up with the same position. If it happens three times, find the previous node and use it as a hint for the next time.

Test Plan: Add some unit test coverage.

…ame position.

Summary: It's not uncommon for memtable reseek to end up with the same position. If it happens three times, find the previous node and use it as a hint for the next time.

Test Plan: Add some unit test coverage.

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@siying has updated the pull request. Re-import the pull request

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @siying!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants