Skip to content

Refactor build_tools/build_detect_version#56

Merged
liukai merged 2 commits into
facebook:masterfrom
sepeth:refactor-detect-version
Jan 6, 2014
Merged

Refactor build_tools/build_detect_version#56
liukai merged 2 commits into
facebook:masterfrom
sepeth:refactor-detect-version

Conversation

@sepeth

@sepeth sepeth commented Jan 5, 2014

Copy link
Copy Markdown
Contributor

Fixes #55, and retains the fix for #11

  • I didn't use awk, same goal can be achieved with cat, and it seems easier to read.
  • Checking whether git exists is safer with "command -v"
  • Last check about build_version.cc is changed/missing is effectively the same with overriding it. I directly write the output to util/build_version.cc
@liukai

liukai commented Jan 6, 2014

Copy link
Copy Markdown
Contributor

New version looks much more clear, thank you!

liukai added a commit that referenced this pull request Jan 6, 2014
Refactor build_tools/build_detect_version
@liukai liukai merged commit be271c3 into facebook:master Jan 6, 2014
@sepeth sepeth deleted the refactor-detect-version branch January 6, 2014 19:52
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
gz pushed a commit to gz/rocksdb that referenced this pull request Dec 13, 2022
mayuehappy pushed a commit to mayuehappy/rocksdb that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants