Skip to content

Fix share_table_files condition in BackupEngine constructor.#62

Merged
igorcanadi merged 1 commit into
facebook:masterfrom
matope:fix-BackupableDBTest-NoDoubleCopy-test-fail
Jan 10, 2014
Merged

Fix share_table_files condition in BackupEngine constructor.#62
igorcanadi merged 1 commit into
facebook:masterfrom
matope:fix-BackupableDBTest-NoDoubleCopy-test-fail

Conversation

@matope

@matope matope commented Jan 10, 2014

Copy link
Copy Markdown
Contributor

When I first make check, I got an error below.

==== Test BackupableDBTest.NoDoubleCopy
utilities/backupable/backupable_db_test.cc:420: IO error: /tmp/rocksdbtest-1000/backupable_db_backup/shared/00010.sst.tmp: No such file or directory
#0   ./backupable_db_test() [0x43846c] ~Status  /home/vagrant/git/rocksdb/./include/rocksdb/status.h:29
#1   ./backupable_db_test() [0x4d9ecb] rocksdb::test::RunAllTests()     /home/vagrant/git/rocksdb/util/testharness.cc:46
#2   /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2aec24cd2de5] ??        ??:0
#3   ./backupable_db_test() [0x42f71e] _start   ??:?
make: *** [check] Error 1

~$ ls /tmp/rocksdbtest-1000/backupable_db_backup/
LATEST_BACKUP  meta  private

shared directory that should exists was not created correctly.
So I fixed an if-condition in BackupEngine constructor. Could you accept this PR if this fix is correct?

That makes BackupableDBTest.NoDoubleCopy test error.
@ghost ghost assigned igorcanadi Jan 10, 2014
@igorcanadi

Copy link
Copy Markdown
Contributor

Tnx @matope . Have you signed CLA? Please refer to: https://github.com/facebook/rocksdb/blob/master/CONTRIBUTING.md

@matope

matope commented Jan 10, 2014

Copy link
Copy Markdown
Contributor Author

@igorcanadi Yes, I signed that.

@igorcanadi

Copy link
Copy Markdown
Contributor

@jamesgpearce I don't see @matope on the list, can you please sync?

igorcanadi added a commit that referenced this pull request Jan 10, 2014
…test-fail

Fix share_table_files condition in BackupEngine constructor.
@igorcanadi igorcanadi merged commit 62197d2 into facebook:master Jan 10, 2014
@matope

matope commented Jan 11, 2014

Copy link
Copy Markdown
Contributor Author

Thanks for your Merge!

@matope matope deleted the fix-BackupableDBTest-NoDoubleCopy-test-fail branch January 11, 2014 04:03
201341 pushed a commit to 201341/rocksdb that referenced this pull request Mar 25, 2020
Make CloudEnvOptions a member variable of CloudEnv
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants