Fix share_table_files condition in BackupEngine constructor.#62
Merged
igorcanadi merged 1 commit intoJan 10, 2014
Merged
Conversation
That makes BackupableDBTest.NoDoubleCopy test error.
Contributor
|
Tnx @matope . Have you signed CLA? Please refer to: https://github.com/facebook/rocksdb/blob/master/CONTRIBUTING.md |
Contributor
Author
|
@igorcanadi Yes, I signed that. |
Contributor
|
@jamesgpearce I don't see @matope on the list, can you please sync? |
igorcanadi
added a commit
that referenced
this pull request
Jan 10, 2014
…test-fail Fix share_table_files condition in BackupEngine constructor.
Contributor
Author
|
Thanks for your Merge! |
201341
pushed a commit
to 201341/rocksdb
that referenced
this pull request
Mar 25, 2020
Make CloudEnvOptions a member variable of CloudEnv
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
lib/levelup.js in closure
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I first
make check, I got an error below.shareddirectory that should exists was not created correctly.So I fixed an if-condition in BackupEngine constructor. Could you accept this PR if this fix is correct?