Add C API for User Defined Timestamp#9914
Conversation
|
Hi @muthukrishnan24! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
2 times, most recently
from
9387ed5 to
d9d83db
Compare
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
from
d9d83db to
304a7ed
Compare
riversand963
left a comment
riversand963
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Could you fix c_test and add some tests there to cover your changes?
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
from
533f640 to
30ced93
Compare
|
Both c_test and format_check failures seem legit. Can you take a look @muthukrishnan24 ? Thanks |
Sure, will look into that |
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
from
e7befba to
0e6cc4f
Compare
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @muthukrishnan24. Forgot to mention that, but can you update HISTORY.md to mention the addition of these new C APIs? |
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
from
2f2ba85 to
245a326
Compare
|
@muthukrishnan24 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 updated History.md |
|
@muthukrishnan24 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@muthukrishnan24 Sorry about the conflicts. |
muthukrishnan24
force-pushed
the
user_timestamp_c
branch
from
45ffb3c to
6f59532
Compare
|
@muthukrishnan24 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 resolved the conflicts and rebased |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
4 participants
Fixes #9889