Trying to package for Fedora, one of the blocking failures is caused by:
$ cargo metadata --manifest-path eden/scm/lib/third-party/rust/fbthrift/Cargo.toml
error: current package believes it's in a workspace when it's not:
current: .../sapling/eden/scm/lib/third-party/rust/fbthrift/Cargo.toml
workspace: .../sapling/eden/scm/Cargo.toml
this may be fixable by adding `lib/third-party/rust/fbthrift` to the `workspace.members` array of the manifest located at: .../sapling/eden/scm/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
But these files doesn't seem to be used at all and can perhaps be removed?
eden/scm/lib/edenfs-client/Cargo.toml uses fbthrift_socket from https://github.com/facebookexperimental/rust-shed.git ,
eden/scm/lib/thrift-types/Cargo.toml uses https://github.com/facebook/fbthrift.git , and nothing seems to reference third-party/rust .
(Use of external git repos is another problem, but that's a different problem.)
Trying to package for Fedora, one of the blocking failures is caused by:
But these files doesn't seem to be used at all and can perhaps be removed?
eden/scm/lib/edenfs-client/Cargo.toml uses fbthrift_socket from https://github.com/facebookexperimental/rust-shed.git ,
eden/scm/lib/thrift-types/Cargo.toml uses https://github.com/facebook/fbthrift.git , and nothing seems to reference third-party/rust .
(Use of external git repos is another problem, but that's a different problem.)