fix(oss): Resolve a number of build issues only visible in OSS#1132
Open
ben-- wants to merge 15 commits into
Open
fix(oss): Resolve a number of build issues only visible in OSS#1132ben-- wants to merge 15 commits into
ben-- wants to merge 15 commits into
Conversation
Summary: Test Plan:
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83070043. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
Thank you for this, I will review it as soon as I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a number of small build fixes -- mostly areas where the OSS EdenFS build had not kept up to date with the internal implementation.
Tested through building Sapling/EdenFS (requires other fixes to run clean):