Support uuid "rng-getrandom" feature #1146
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Required in D85438479, which contains a handwritten Cargo.toml (fbcode/pyrefly/pyrefly_wasm/Cargo.toml) that gets incorporated into an Autocargo-generated Cargo.lock (fbcode/pyrefly/Cargo.lock). In order for the handwritten Cargo.toml to be able to use uuid with "rng-getrandom", the Cargo.lock generation needs to have offline access to all the transitive dependencies pulled by this feature. https://www.internalfb.com/code/fbsource/[0cc72b95913a155b4ae4b660196a25e4c23cd6b1]/fbcode/pyrefly/pyrefly_wasm/Cargo.toml?lines=17%2C26 Reviewed By: diliop Differential Revision: D85680730
|
@yangdanny97 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85680730. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Required in D85438479, which contains a handwritten Cargo.toml (fbcode/pyrefly/pyrefly_wasm/Cargo.toml) that gets incorporated into an Autocargo-generated Cargo.lock (fbcode/pyrefly/Cargo.lock).
In order for the handwritten Cargo.toml to be able to use uuid with "rng-getrandom", the Cargo.lock generation needs to have offline access to all the transitive dependencies pulled by this feature.
https://www.internalfb.com/code/fbsource/[0cc72b95913a155b4ae4b660196a25e4c23cd6b1]/fbcode/pyrefly/pyrefly_wasm/Cargo.toml?lines=17%2C26
Reviewed By: diliop
Differential Revision: D85680730