Skip to content

[docs] document super smartlog#270

Closed
shish wants to merge 1 commit into
facebook:mainfrom
shish:pr270
Closed

[docs] document super smartlog#270
shish wants to merge 1 commit into
facebook:mainfrom
shish:pr270

Conversation

@shish

@shish shish commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Stack created with Sapling. Best reviewed with ReviewStack.

[docs] document super smartlog

Summary: Being able to see PR status from the command line is my favourite feature, I don't want it to be buried in a footnote :)

Summary: Being able to see PR status from the command line is my favourite feature, I don't want it to be buried in a footnote :)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@shish has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Dec 1, 2022
Summary:
Stack created with [Sapling]
* #270
* __->__ #267
* #266
* #264

[docs] syntax-highlighting for smartlogs

This doesn't work in all cases (trying to come with with a regex that correctly handles practically arbitrary input never will) - but it seems to cover the majority of examples that are in the docs in practice.

Notable omissions:
- non-active local bookmarks aren't spotted
- no differentiation between draft and public commits

Example:
{F806537223}

Pull Request resolved: #267

Test Plan: Looked through all of the pages manually

Reviewed By: quark-zju

Differential Revision: D41544319

Pulled By: shish

fbshipit-source-id: 1a3bf691a5f53de90c4bb36a4c2613cf1a5edb0c
facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2022
Summary:
Stack created with [Sapling]
* #270
* #267
* __->__ #266
* #264

[docs] Regenerate command auto-docs

 I want to add syntax highlighting to the auto-generated docs, but they are out of date, so first let's update them

Pull Request resolved: #266

Reviewed By: bolinfest

Differential Revision: D41544316

Pulled By: shish

fbshipit-source-id: f6523275073add5a90982963089012e46f516d29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants