(build): Support sapling in tag-name.sh#439
Closed
vegerot wants to merge 1 commit into
Closed
Conversation
Summary: Currently, tag-name.sh only works with git. This is fine, because it's only used in GitHub CI, but I also want to use this script for local builds (which will be in a future commit). This commit will use either sl or git for creating tag names. Test-Plan: Automated testing blocked on facebook#447 ```sh ❯ ./ci/tag-name.sh 0.2.20230107-190233-hc1336fcb ```
Contributor
|
@bolinfest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
Summary: Pull Request resolved: facebook/CacheLib#439 Reviewed By: yangdanny97 Differential Revision: D99315659 fbshipit-source-id: 7820fd4dab4431b606e133562f374a66275456c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(build): Support sapling in tag-name.sh
Summary: Currently, tag-name.sh only works with git. This is fine, because
it's only used in GitHub CI, but I also want to use this script for local
builds (which will be in a future commit). This commit will use either sl or
git for creating tag names.
Test-Plan: Automated testing blocked on #447
Stack created with Sapling. Best reviewed with ReviewStack.
make oss#440