Skip to content

Tags: facebook/sapling

Tags

0.2.20260522-084851+1e764c94

Toggle 0.2.20260522-084851+1e764c94's commit message
backtrace-python: improve compatibility on macOS release build

Summary:
I noticed the latest homebrew macOS OSS build does not resolve Python frames in
backtrace. It turns out that we need to match the underscore versions of the
function names. See the added comment.

Reviewed By: muirdm

Differential Revision: D106095666

fbshipit-source-id: 9bc6fcf1eeba77f4d561f32b5a128ea5a16295c3

test-release-1

Toggle test-release-1's commit message
backtrace-python: improve compatibility on macOS release build

Summary:
I noticed the latest homebrew macOS OSS build does not resolve Python frames in
backtrace. It turns out that we need to match the underscore versions of the
function names. See the added comment.

Reviewed By: muirdm

Differential Revision: D106095666

fbshipit-source-id: 9bc6fcf1eeba77f4d561f32b5a128ea5a16295c3

0.2.20260317-201835+0234c21f

Toggle 0.2.20260317-201835+0234c21f's commit message
Support TypeSystem <-> SerializableTypeSystem conversion

Summary:
Adds round-trip conversion between `SerializableTypeSystem` and `TypeSystem` instances. (specifically `IndexedTypeSystem`).

- Construction uses `TryFrom<SerializableTypeSystem>`
- Any `TypeSystem` has a default serialization implementating using URI-based export
- Specific `TypeSystem` implementations can override this implementation where appropriate.

Reviewed By: praihan

Differential Revision: D96979371

fbshipit-source-id: fa193344bb5c6fde4b56c4699ff206867ab833d2

0.2.20250521-115337+25ed6ac4

Toggle 0.2.20250521-115337+25ed6ac4's commit message
fix some minor lints in TreeInodes.cpp

Summary: I was playing with `TreeInodes.cpp` and I found a few lint warnings and a wrong comment.

Reviewed By: jdelliot

Differential Revision: D75092377

fbshipit-source-id: 67dba155f5ae76d5a18ef167b2c48ca5851cda48

0.2.20241203-120811+a2174689

Toggle 0.2.20241203-120811+a2174689's commit message
fix(scm-prompt): suppress cd output (#985)

Summary:
If a user has a `chpwd` hook that prints output, it will be prepended to the
`dir` variable which breaks the prompt. This change suppresses the output of
`cd` to prevent this.

Alternatively I considered doing `cd -q` to skip running the chpwd hook, but
decided against it.

Pull Request resolved: #985

Test Plan:
```zsh
$ zsh --no-rcs
$ source ~/workspace/github.com/facebook/sapling/eden/scm/contrib/scm-prompt.sh && _scm_prompt
# things should be fine
$ say_hi() { echo hello } && chpwd_functions+=(say_hi) && _scm_prompt
```
prior to this commit, the prompt would be broken. After this commit, it should
be fine.

Background: in my particular case, I have a `chpwd` hook that
[sources custom scripts](https://github.com/vegerot/dotfiles/blob/032f88715fa2911bec6b3c09aa012145bb1dae7e/.zshrc#L250-L252)
depending on the directory, and will tell me if it does so. This was breaking
the prompt, so I added this change to fix it.

Reviewed By: quark-zju

Differential Revision: D66384725

fbshipit-source-id: e03d18887a27fc6c55da1dc7347eacf0fa38cde7

0.2.20240718-145624+f4e9df48

Toggle 0.2.20240718-145624+f4e9df48's commit message
stats: add new counters to existing docs

Summary:
# Context

I added new stats in D58492412, so now I have to document them. I've updated the wiki, but I still need to update the markdown docs stored in the repo.

# This diff

Updates the stats docs to match reality.

Reviewed By: fanzeyi

Differential Revision: D59932131

fbshipit-source-id: fe17c2ee986e182d00d35121827346e5c210ba1a

0.2.20240219-172743+3e819974

Toggle 0.2.20240219-172743+3e819974's commit message
alerts: make it compatible with Python3.8 (#838)

Summary:
`re.Pattern[str]` is not valid in Python 3.8

Pull Request resolved: #838

Test Plan:
```
Python 3.8.17 (default, Jul  9 2023, 20:57:35)
[Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> from typing import Optional
>>> show_after_crashes_regex: Optional[re.Pattern[str]] = None
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'type' object is not subscriptable
>>> show_after_crashes_regex: Optional[re.Pattern] = None
>>>
```

Reviewed By: zzl0

Differential Revision: D53903964

fbshipit-source-id: 412f4ad5d6011b0da70c47f31f6c919b9c6a8037

0.2.20240116-133042+8acecb66

Toggle 0.2.20240116-133042+8acecb66's commit message
AnimatedReorderGroup: ignore small distance animation to workaround V…

…SCode button rendering

Summary:
I notice that when committing, while the optimistic state matches the final
state, the commits below moves up and down unnecessarily.

Upon debugging using a breakpoint in AnimatedReorderGroup when it decides to
animate, I found a 4px animation, and the VSCode buttons [Uncommit] [Split]
were in its "primary" style, with a larger height first rendered. Apparently
the VSCode button then change to the specified "icon" style, with a different
height, but it does not do that in the first render. There are enough pitfalls
in VSCode toolkit we might want to just replace it... but for now let's
workaround the issue by ignoring small distance animation.

Screenshot when hitting the breakpoint - buttons have wrong style and height:
 {F1272099178}

Reviewed By: zzl0

Differential Revision: D52667618

fbshipit-source-id: c183d7c60ce0e5da19afd39bf696cff89f5650a3

0.2.20231113-145254+995db0d6

Toggle 0.2.20231113-145254+995db0d6's commit message
tests: disable fsmonitor.fallback-on-watchman-exception

Summary: This can cover up unexpected bugs/crashes in Watchman integration, so don't fall back for tests.

Reviewed By: quark-zju

Differential Revision: D51265960

fbshipit-source-id: cd97cc38e5a9a5ee333aff5b18cb9dd2cb779298

0.2.20230523-092610+f12b7eee

Toggle 0.2.20230523-092610+f12b7eee's commit message
Updating submodules

Summary:
GitHub commits:

facebook/ocamlrep@98bea9c
facebook/proxygen@bdb3160
facebookexperimental/rust-shed@1fca41f

Reviewed By: jurajh-fb

fbshipit-source-id: 30f88b199cdb5b977e66e4bf55f7c249a58256f5