Tags: facebook/sapling
Tags
renable github actions for linux (#1135) Summary: Pull Request resolved: #1135 Renable mononoke linux github actions so that folks externally can see that it current builds, and so they can see the breaks easily if it later doesn't build. Added support for pinning rust version as during developement needed to pin to rust 1.90 as didn't yet compile with 1.91. In the meantime 1.91 support landed so pinned to 1.91. Also saw that it was running out of disk space on the github actions runner so switched it to use MinSizeRel cmake build type and added a cargo mapping for it Reviewed By: genevievehelsel Differential Revision: D82818583 fbshipit-source-id: 6f0c54caa5b9593135a6977b1409f416ca622d81
renable github actions for linux (#1135) Summary: Pull Request resolved: #1135 Renable mononoke linux github actions so that folks externally can see that it current builds, and so they can see the breaks easily if it later doesn't build. Added support for pinning rust version as during developement needed to pin to rust 1.90 as didn't yet compile with 1.91. In the meantime 1.91 support landed so pinned to 1.91. Also saw that it was running out of disk space on the github actions runner so switched it to use MinSizeRel cmake build type and added a cargo mapping for it Reviewed By: genevievehelsel Differential Revision: D82818583 fbshipit-source-id: 6f0c54caa5b9593135a6977b1409f416ca622d81
github: attempt to build linux arm64 binary Summary: The `manylinux` Docker image contains both the x64 and arm64 versions. So let's try build the arm64 linux binary too. Note there is [no `ubuntu-arm-latest`](https://github.com/orgs/community/discussions/148648#discussioncomment-11858287). Reviewed By: muirdm Differential Revision: D75883597 fbshipit-source-id: 1dd9a216f7e15aaf45ef0fa0fa68726e45252f3f
fix some minor lints in TreeInodes.cpp Summary: I was playing with `TreeInodes.cpp` and I found a few lint warnings and a wrong comment. Reviewed By: jdelliot Differential Revision: D75092377 fbshipit-source-id: 67dba155f5ae76d5a18ef167b2c48ca5851cda48
Replace self.skipTest with skip.py entries inside changes_test.py Pt1��� …: Windows Tests on Nix Summary: # Context BadTestsDetector is unhappy with our use of self.skipTest to skip tests running on the wrong OS or VCS. eg. https://www.internalfb.com/diff/D74989552 Replace self.skipTest with entries in skip.py # This Diff Convert **TestWin to use skipTests Reviewed By: jdelliot Differential Revision: D75019937 fbshipit-source-id: fdb0c581ae4d7bf051c4d2cdf7e30fe3c87856fa
fix(scm-prompt): suppress cd output (#985) Summary: If a user has a `chpwd` hook that prints output, it will be prepended to the `dir` variable which breaks the prompt. This change suppresses the output of `cd` to prevent this. Alternatively I considered doing `cd -q` to skip running the chpwd hook, but decided against it. Pull Request resolved: #985 Test Plan: ```zsh $ zsh --no-rcs $ source ~/workspace/github.com/facebook/sapling/eden/scm/contrib/scm-prompt.sh && _scm_prompt # things should be fine $ say_hi() { echo hello } && chpwd_functions+=(say_hi) && _scm_prompt ``` prior to this commit, the prompt would be broken. After this commit, it should be fine. Background: in my particular case, I have a `chpwd` hook that [sources custom scripts](https://github.com/vegerot/dotfiles/blob/032f88715fa2911bec6b3c09aa012145bb1dae7e/.zshrc#L250-L252) depending on the directory, and will tell me if it does so. This was breaking the prompt, so I added this change to fix it. Reviewed By: quark-zju Differential Revision: D66384725 fbshipit-source-id: e03d18887a27fc6c55da1dc7347eacf0fa38cde7
stats: add new counters to existing docs Summary: # Context I added new stats in D58492412, so now I have to document them. I've updated the wiki, but I still need to update the markdown docs stored in the repo. # This diff Updates the stats docs to match reality. Reviewed By: fanzeyi Differential Revision: D59932131 fbshipit-source-id: fe17c2ee986e182d00d35121827346e5c210ba1a
alerts: make it compatible with Python3.8 (#838) Summary: `re.Pattern[str]` is not valid in Python 3.8 Pull Request resolved: #838 Test Plan: ``` Python 3.8.17 (default, Jul 9 2023, 20:57:35) [Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import re >>> from typing import Optional >>> show_after_crashes_regex: Optional[re.Pattern[str]] = None Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: 'type' object is not subscriptable >>> show_after_crashes_regex: Optional[re.Pattern] = None >>> ``` Reviewed By: zzl0 Differential Revision: D53903964 fbshipit-source-id: 412f4ad5d6011b0da70c47f31f6c919b9c6a8037
Updating submodules Summary: GitHub commits: facebook/CacheLib@af319c5 facebook/fb303@4816112 facebook/fbthrift@eca43d4 facebook/litho@509ddaa facebook/mvfst@77ba7e7 facebook/proxygen@9095290 facebook/rocksdb@f2732d0 facebook/squangle@505288f facebook/wangle@4bbb245 facebook/watchman@63865e4 facebookexperimental/edencommon@a493578 facebookexperimental/rust-shed@dd07461 facebookincubator/fizz@6182dd9 facebookincubator/katran@c60a7ec facebookresearch/vrs@fe46daf pytorch/FBGEMM@66a8779 Reviewed By: bigfootjon fbshipit-source-id: 5eb28051321fb97f12b0ab45c704495c82eb4b5f
Update commit sync config and CommitSyncRepos Summary: This diff adds a new field to the `CommitSyncRepos` and `CommitSyncer` structs, which stores the map from submodule path to its Mononoke repo instance. This map will be used in the `rewrite_commit` function in `eden/mononoke/commit_rewriting/cross_repo_sync/src/lib.rs` to support expanding git submodule file changes. One annoying thing about this change is that **these structs are used in many places**, but not all of them will actually be rewriting commits, meaning that **they don't need to load the repo's submodule dependencies**. Instead of passing empty hashmaps everywhere, I decided to set the field to optional, so I explicitly set to `None` where this is not needed. I added `TODO(T174902563)` to all code pointers that I think will need to load these repos. I'll review each one in more detail after this diff and will implement the code pointers where they're needed. In the diff where I actually start expanding submodules (D52833563) I'll check if the map is set before starting the expand codepath. FYI, I also added a TODO to possibly add unit tests for this later. TBH, since I'll invest significant time on integration tests, I'm not sure if adding unit tests will be worth the time spent, because this workflow is hard to really reproduce in unit tests, since it involves creating git repos and using submodules (i.e. which is way simpler in integration/E2E tests). Reviewed By: mitrandir77 Differential Revision: D53316026 fbshipit-source-id: 29b9c1f3f58784863ce81a03f489dc73cd9fb2f9
PreviousNext