Allow custom records to be created from rust.#199
Closed
matts1 wants to merge 1 commit into
Closed
Conversation
This allows for a few things: * Functions such as bazel's `provider` function can now be implemented in pure rust. * Record objects can now be registered into globals (eg. bazel's DefaultInfo object)
|
This pull request has been imported. If you are a Meta employee, you can view this in D107725096. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
I think this fixes #156 but am not totally sure. |
ndmitchell
approved these changes
Jun 8, 2026
ndmitchell
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync Bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jun 8, 2026
Summary: This allows for a few things: * Functions such as bazel's `provider` function can now be implemented in pure rust. * Record objects can now be registered into globals (eg. bazel's DefaultInfo object) X-link: facebook/starlark-rust#199 Reviewed By: ndmitchell Differential Revision: D107725096 fbshipit-source-id: 83c0f24a20f94b8b2fe79d54296b6156d28e29d7
|
This pull request has been merged in 81ff440. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for a few things:
providerfunction can now be implemented in pure rust.