Skip to content

Allow custom records to be created from rust.#199

Closed
matts1 wants to merge 1 commit into
facebook:mainfrom
matts1:push-mzptqoqxnsrq
Closed

Allow custom records to be created from rust.#199
matts1 wants to merge 1 commit into
facebook:mainfrom
matts1:push-mzptqoqxnsrq

Conversation

@matts1

@matts1 matts1 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This allows for a few things:

  • Functions such as bazel's provider function can now be implemented in pure rust.
  • Record objects can now be registered into globals (eg. bazel's DefaultInfo object)
This allows for a few things:
* Functions such as bazel's `provider` function can now be implemented
  in pure rust.
* Record objects can now be registered into globals (eg. bazel's
  DefaultInfo object)
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2026
@meta-codesync

meta-codesync Bot commented Jun 6, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D107725096. (Because this pull request was imported automatically, there will not be any future comments.)

@PhilipMetzger

Copy link
Copy Markdown
Contributor

I think this fixes #156 but am not totally sure.

@ndmitchell ndmitchell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

meta-codesync Bot pushed a commit to facebook/buck2 that referenced this pull request Jun 8, 2026
Summary:
This allows for a few things:
* Functions such as bazel's `provider` function can now be implemented in pure rust.
* Record objects can now be registered into globals (eg. bazel's DefaultInfo object)

X-link: facebook/starlark-rust#199

Reviewed By: ndmitchell

Differential Revision: D107725096

fbshipit-source-id: 83c0f24a20f94b8b2fe79d54296b6156d28e29d7
@meta-codesync meta-codesync Bot closed this in 81ff440 Jun 8, 2026
@meta-codesync

meta-codesync Bot commented Jun 8, 2026

Copy link
Copy Markdown

This pull request has been merged in 81ff440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

3 participants