Skip to content

Conversation

@mellyeliu
Copy link
Member

Small patch for unitless '0' strings to allow margin: '0' syntax

https://developer.mozilla.org/en-US/docs/Web/CSS/length#syntax

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@github-actions
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.15.3 compare
node ./compare.js /tmp/tmp.IMy4z0i5c6 /tmp/tmp.yI1J85iKbe

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,190 1,190 1.00
· minified 3,541 3,541 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,223 1,223 1.00
· minified 3,216 3,216 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,853 99,853 1.00
· minified 747,541 747,541 1.00
@mellyeliu mellyeliu marked this pull request as ready for review August 28, 2025 17:16
@github-actions
Copy link

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.15.3 compare
node ./compare.js /tmp/tmp.BpVqzuSxKK /tmp/tmp.zTuhLcut4B

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 642 641 1.00 -
· complex create 190 195 1.03 +
babel-plugin: stylex.createTheme
· basic themes 452 454 1.00 +
· complex themes 43 43 1.00
@mellyeliu mellyeliu merged commit b82163d into main Aug 28, 2025
10 of 11 checks passed
@mellyeliu mellyeliu deleted the zero-fix branch August 28, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants