fix: Allow defineConsts to take numbers as values with TypeScript
#1240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
There seems to be a divergence between the type of
TTokensin Flow vs. in TypeScript. This causesdefineConststo reject number values in TypeScript, like so:Sync the type of
TTokensinpackages/@stylexjs/stylex/src/types/StyleXTypes.d.tsagainst that ofpackages/@stylexjs/stylex/src/types/StyleXTypes.jsto fix this.Additional Context
Test case added to
packages/typescript-tests/src/typetests.ts.Pre-flight checklist
Contribution Guidelines