Skip to content

[chore] Update Flow to 271 #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nmn merged 4 commits into from
Oct 26, 2025
Merged

[chore] Update Flow to 271 #1299

nmn merged 4 commits into from
Oct 26, 2025

Conversation

@nmn
Copy link
Collaborator

@nmn nmn commented Oct 26, 2025 •
edited
Loading

What changed / motivation ?

Update Flow to 0.271 and make the changes needed to the libdefs etc to ensure no type errors.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2025
@nmn nmn changed the title [chore] Update Flow to 272 Oct 26, 2025
@github-actions
Copy link

github-actions bot commented Oct 26, 2025 •
edited
Loading

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.16.2 compare
node ./compare.js /tmp/tmp.UoQxJcNPPJ /tmp/tmp.hchkwKfozX

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 643 635 0.99 -
· complex create 189 200 1.06 !!
babel-plugin: stylex.createTheme
· basic themes 459 454 0.99 -
· complex themes 43 42 0.98 -
@github-actions
Copy link

github-actions bot commented Oct 26, 2025 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.16.2 compare
node ./compare.js /tmp/tmp.7mWS4VqY5o /tmp/tmp.zE4Uskx8zg

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,282 1,282 1.00
· minified 4,025 4,025 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,223 1,223 1.00
· minified 3,216 3,216 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,853 99,853 1.00
· minified 747,541 747,541 1.00
@nmn nmn force-pushed the chore/update-deps-from-flow-0.261 branch from 2ef0566 to e4b32ba Compare October 26, 2025 18:20
@nmn nmn merged commit 4db6722 into main Oct 26, 2025
9 checks passed
mellyeliu added a commit that referenced this pull request Oct 31, 2025
@mellyeliu
Revert "[chore] Update Flow to 0.289 (#1299)"
670cc54 
This reverts commit 4db6722.
hiteshshetty-dev pushed a commit to hiteshshetty-dev/stylex that referenced this pull request Nov 8, 2025
@nmn @hiteshshetty-dev
[chore] Update Flow to 0.289 (facebook#1299)
3210247 
* [chore] Update Flow to 272

* [chore] Update Flow to 273.1

* [chore] Update Flow to 0.286

* [chore] Update Flow to 0.289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@nmn @mellyeliu