[babel-plugin] additional externals for rollup build #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@babel/helper-module-imports` and `postcss-value-parser` packages are dependencies of `@stylexjs/babel-plugin` so they can be externalized in the rollup build.
henryqdineen
requested review from
Jta26,
ezzak,
mellyeliu,
necolas,
nmn and
vincentriemer
as code owners
meta-cla
bot
added
the
CLA Signed
mellyeliu
approved these changes
Oct 29, 2025
2 tasks
hiteshshetty-dev
pushed a commit
to hiteshshetty-dev/stylex
that referenced
this pull request
Nov 8, 2025
The `@babel/helper-module-imports` and `postcss-value-parser` packages are dependencies of `@stylexjs/babel-plugin` so they can be externalized in the rollup build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
This is not causing any issues but I noticed that the rollup config for
@stylexjs/babel-pluginwas not externalizing a couple packages that could be:@babel/helper-module-importspostcss-value-parserThis should be safe since those packages are listed as
dependenciesand will be installed by consumers. This will reduce bundle by ~8% and seems appropriate by following the existing pattern of externalizing third-party packages.Note: some changes were from prettier formatting. It looks like the
prettier:reportscript does not check.mjsfiles so theserollup.config.mjsfiles have not been formatted. Let me know if I should updateprettier:reportin a separate PR.Pre-flight checklist
Contribution Guidelines