Skip to content

Conversation

@nmn
Copy link
Collaborator

@nmn nmn commented Nov 24, 2025

What changed / motivation ?

Updating our default config options to streamline debug and dev options.

  • enableDebugClassNames is now false by default
  • enableDevClassNames will once again be turned on when dev is true

Outside of that, the default values of all config options have been unified.


Additionally, The unplugin package has been updated with better types and to default with treeshakingCompensation on for vite, rollup and rolldown.

These bundlers need this option to handle theme imports correctly.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.17.0 compare
node ./compare.js /tmp/tmp.pv7kVrQxzg /tmp/tmp.s6zIqEQ3cz

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 545 534 0.98 -
· complex create 67 67 1.00
babel-plugin: stylex.createTheme
· basic themes 443 446 1.01 +
· complex themes 44 44 1.00
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.17.0 compare
node ./compare.js /tmp/tmp.uwdws1cdq1 /tmp/tmp.uY3IppsjDc

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,311 1,311 1.00
· minified 4,150 4,150 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,223 1,223 1.00
· minified 3,216 3,216 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,853 99,853 1.00
· minified 747,541 747,541 1.00
Copy link
Member

@mellyeliu mellyeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests

@nmn nmn force-pushed the fix/improve-default-config branch from d1871e1 to 23ce29e Compare November 24, 2025 06:03
@nmn nmn merged commit bb49888 into main Nov 24, 2025
9 checks passed
@nmn nmn deleted the fix/improve-default-config branch November 24, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants