Skip to content

feat(babel-plugin): add disallowedPropertiesValidation option #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mellyeliu merged 2 commits into from
Jan 4, 2026
Merged

feat(babel-plugin): add disallowedPropertiesValidation option #1424

mellyeliu merged 2 commits into from
Jan 4, 2026

Conversation

@Faizanq
Copy link
Contributor

@Faizanq Faizanq commented Jan 3, 2026

Add config option to control validation behavior for disallowed shorthand properties (border, background, animation, etc).

Changes

  • Added disallowedPropertiesValidation option with three modes:
    • 'throw' (default): Throws error for disallowed properties
    • 'warn': Logs warning and skips property
    • 'silent': Silently skips property

Use case

Allows gradual migration of existing codebases that use disallowed shorthand properties without breaking the build.

Fixes #1423
@Faizanq
feat(babel-plugin): add disallowedPropertiesValidation option
102b1d6 
Add config option to control validation behavior for disallowed shorthand
properties (border, background, animation, etc).

Options: 'throw' (default), 'warn', 'silent'

Fixes facebook#1423
@vercel
Copy link

vercel bot commented Jan 3, 2026

@Faizanq is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.
@meta-cla
Copy link

meta-cla bot commented Jan 3, 2026

Hi @Faizanq!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
nmn
nmn approved these changes Jan 3, 2026
View reviewed changes
Copy link
Collaborator

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now. We should update the babel plugin to never throw on these properties by default, and create a new option to manually validate for React Native instead.
mellyeliu
mellyeliu reviewed Jan 3, 2026
View reviewed changes
@Faizanq
refactor(babel-plugin): rename disallowedPropertiesValidation to prop…
78c810e 
…ertyValidationMode

- Renamed option per review feedback
- Changed default from 'throw' to 'silent' (less noisy)
- Simplified warning message
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2026
@mellyeliu
Copy link
Member

mellyeliu commented Jan 4, 2026

We might want to log in dev or for RN but can follow up with a patch
@mellyeliu mellyeliu merged commit caecddc into facebook:main Jan 4, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@Faizanq @mellyeliu @nmn