Missed ./acceptor/EvbHandshakeHelper.cpp in CMakeLists.txt#113
Closed
capveg wants to merge 1 commit into
Closed
Conversation
Author
|
this was merged internally; closing. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: facebook/sapling#113 GitHub Actions was failing at apt-get stage, error message suggested adding an apt-get update as remedy. Added in this diff and it indeed works. The actions build fails later on missing mio::net module when building mysql async, but that's unrelated to this change. Reviewed By: farnz Differential Revision: D34368662 fbshipit-source-id: f0a00da3ee740ae4443a328616e792ea615c922c
dgrnbrg-meta
added a commit
to dgrnbrg-meta/wangle
that referenced
this pull request
Mar 11, 2022
Summary: X-link: facebook/fboss#113 Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly. When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`. This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available. Reviewed By: vivekspai Differential Revision: D34732506 fbshipit-source-id: c7d753c0a4bcc33870a6019b2f2936d489595f3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mingtaoy 's recent change broken open source wangle, which broke open source fbthrift, which broke open source fboss :-( This patch fixes it.
FYI: @eduardo-elizondo