Skip to content

correct mmap error check #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richardsonnick wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

correct mmap error check #4560

richardsonnick wants to merge 1 commit into from
+3 −1

Conversation

@richardsonnick
Copy link

@richardsonnick richardsonnick commented Dec 23, 2025

According to the mmap docs MAP_FAILED is returned upon error:

On success, mmap() returns a pointer to the mapped area. On
error, the value MAP_FAILED (that is, (void *) -1) is returned,
and errno is set to indicate the error.

Update mmap error validation to check for MAP_FAILED instead of NULL. POSIX specifies that mmap returns MAP_FAILED (-1) on failure.

Reported-by: Clang 21 Static Analyzer
@richardsonnick
correct mmap error check
392c962 
Update mmap error validation to check for MAP_FAILED instead of NULL.
POSIX specifies that mmap returns MAP_FAILED (-1) on failure.
@meta-cla meta-cla bot added the CLA Signed label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

1 participant

@richardsonnick