Migrate OSS project to handle protocol split#58
Closed
Mizuchi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Summary: X-link: facebook/CacheLib#386 X-link: facebook/fb303#67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74687663 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74687663 |
Mizuchi
added a commit
to Mizuchi/edencommon
that referenced
this pull request
May 14, 2025
Summary: X-link: facebookexperimental/moxygen#58 X-link: facebook/CacheLib#386 X-link: facebook/fb303#67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663
Mizuchi
added a commit
to Mizuchi/mcrouter
that referenced
this pull request
May 14, 2025
Summary: X-link: facebook/openr#158 X-link: facebook/fboss#434 X-link: facebookincubator/fizz#162 X-link: facebookexperimental/moxygen#58 X-link: facebook/CacheLib#386 X-link: facebook/fb303#67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663
Mizuchi
added a commit
to Mizuchi/folly
that referenced
this pull request
May 14, 2025
Summary: X-link: facebook/mcrouter#468 X-link: facebookexperimental/edencommon#26 X-link: fairinternal/unified_parallelism#15 X-link: facebookincubator/hsthrift#152 X-link: facebook/mvfst#395 X-link: prestodb/presto#25113 X-link: facebook/fboss#434 X-link: facebookincubator/fizz#162 X-link: facebookexperimental/moxygen#58 X-link: facebook/CacheLib#386 X-link: facebook/fb303#67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663
Contributor
|
Diff was abandoned |
afrind
pushed a commit
that referenced
this pull request
Mar 12, 2026
* Static linking fixes, sync conflict auto-resolution, snapshot-latest draft fix - BUNDLE_DEPS: add GFLAGS_SHARED=OFF and Boost_USE_STATIC_LIBS for CONFIG-mode packages that ignore CMAKE_FIND_LIBRARY_SUFFIXES - BUNDLE_DEPS: use shared libunwind (system .a is not -fPIC on Ubuntu) - upstream-sync: auto-resolve github_hashes conflicts with -X ours, notify Slack/email on unresolvable conflicts - publish-artifacts: fix snapshot-latest release stuck as draft * Fix BUNDLE_DEPS: Linux-only .a suffix, skip libunwind for bundled builds * Keep libunwind .so for BUNDLE_DEPS: find with shared preference, skip folly re-find * Fix glog transitive libunwind.a PIC failure on x86_64 FindGlog.cmake internally calls find_package(LibUnwind), which with CMAKE_FIND_LIBRARY_SUFFIXES=".a" (set by BUNDLE_DEPS) picks up libunwind.a. On Debian/Ubuntu x86_64, that file is not compiled with -fPIC, causing PIE link failure. Patch glog::glog's link interface to use libunwind.so instead. * Make GFLAGS_SHARED OFF Linux-only to fix macOS dual linkage On macOS, glog is always shared (homebrew has no libglog.a). glog.dylib links gflags.dylib, so using static gflags (GFLAGS_SHARED OFF) causes dual-linkage crashes. Keep gflags shared on macOS to match glog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/CacheLib#386
X-link: facebook/fb303#67
fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system.
Differential Revision: D74687663