feat(encodings + SubIntSplit): Extension to SubIntSplit Cost Model Selection#880
Open
David-C-L wants to merge 22 commits into
Open
feat(encodings + SubIntSplit): Extension to SubIntSplit Cost Model Selection#880David-C-L wants to merge 22 commits into
David-C-L wants to merge 22 commits into
Conversation
…erload with statistics for use in SubIntSplit
…s for BlockBitPacking, PFOR, and SIMDBitpacking
…h bit width histogram
…th Statistics in selection
…lection to consider PFOR, SimdForBitpack and BlockBitPacking
…d existing SubIntSplit tests to test PFOR, SimdBitpack, BlockBitPack integration
…cs for use in SubIntSplit
…or use in SubIntSplit
…h monotonic counter and absolute delta
…s for For and Delta
…h Delta and FOR selection
…atistics for use in SubIntSplit
…rt freq part tiers (deduplicating DominantValue logic where possible) and implement freq part cost model
…egrate size estimation in selector
…h FreqPart selection
meta-cla
Bot
added
the
CLA Signed
David-C-L
changed the title
|
@srsuryadev has imported this pull request. If you are a Meta employee, you can view this in D108818670. |
apurva-meta
approved these changes
Jun 17, 2026
srsuryadev
requested changes
Jun 29, 2026
srsuryadev
left a comment
srsuryadev
left a comment
Contributor
There was a problem hiding this comment.
@David-C-L Let us update the test plan for cost model selection changes based on microbenchmark results as well to avoid spurious selections https://github.com/facebookincubator/nimble/tree/main/dwio/nimble/encodings/benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for extending the SubIntSplit Cost Models to support:
Includes additional methods for estimating size from Statistics in some of the encodings, and adds each of the above encodings to the consideration for the SubIntSplit dynamic programming algorithm for selecting bit-splits and encodings.